Repository navigation
fix: read the alias-suffixed id token note on logout - #177
Merged
clement-dufaure merged 1 commit intoOct 28, 2026
Merged
Conversation
Signed-off-by: Aditya Nikam <adityanikam9502@gmail.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Collaborator
|
OK, so we have to replace it later by the helper getFederatedIdTokenKey() in a breakin version of the adapter (compatibility 26.8+) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176
Since Keycloak 26.8, the identity provider stores the ID token in the user session note
FEDERATED_ID_TOKEN:<alias>instead ofFEDERATED_ID_TOKEN.getIdTokenForLogoutonly read the bare note, so on 26.8 it found no token and sent noid_token_hintwhen Keycloak starts the logout.It now reads the alias-suffixed note first and falls back to the bare one, which is what Keycloak 26.8 does itself, so sessions created on earlier versions keep working. The method is in the base class, so FranceConnect and AgentConnect both get the fix. The key is built here because the build still uses Keycloak 26.7.2, which has no helper for it.
Added two unit tests for
getIdTokenForLogout(the suffixed note is preferred, and the bare note is used when there is no suffixed one). The first one fails without the change. I have not run this against a real Keycloak 26.8 or a ProConnect account.