Skip to content

fix: read the alias-suffixed id token note on logout - #177

Merged
clement-dufaure merged 1 commit into
InseeFr:masterfrom
adityaanikam:fix-alias-suffixed-id-token-176
Oct 28, 2026
Merged

clement-dufaure merged 1 commit into
InseeFr:masterfrom
adityaanikam:fix-alias-suffixed-id-token-176

Conversation

@adityaanikam

Copy link
Copy Markdown
Contributor

Fixes #176

Since Keycloak 26.8, the identity provider stores the ID token in the user session note FEDERATED_ID_TOKEN:<alias> instead of FEDERATED_ID_TOKEN. getIdTokenForLogout only read the bare note, so on 26.8 it found no token and sent no id_token_hint when Keycloak starts the logout.

It now reads the alias-suffixed note first and falls back to the bare one, which is what Keycloak 26.8 does itself, so sessions created on earlier versions keep working. The method is in the base class, so FranceConnect and AgentConnect both get the fix. The key is built here because the build still uses Keycloak 26.7.2, which has no helper for it.

Added two unit tests for getIdTokenForLogout (the suffixed note is preferred, and the bare note is used when there is no suffixed one). The first one fails without the change. I have not run this against a real Keycloak 26.8 or a ProConnect account.

Signed-off-by: Aditya Nikam <adityanikam9502@gmail.com>
Copilot AI balanced review requested due to automatic review settings October 16, 2026 18:48

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@clement-dufaure

Copy link
Copy Markdown
Collaborator

OK, so we have to replace it later by the helper getFederatedIdTokenKey() in a breakin version of the adapter (compatibility 26.8+)

@clement-dufaure
clement-dufaure merged commit e21dc9c into InseeFr:master Oct 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Support alias-suffixed FEDERATED_ID_TOKEN notes with Keycloak 26.8

3 participants